Skip to content

draft: enhance: prevent deadlocks during S3 CRT client finalization - #612

Open
jiaqizho wants to merge 1 commit into
milvus-io:mainfrom
jiaqizho:refine-s3-crt-client-holder
Open

draft: enhance: prevent deadlocks during S3 CRT client finalization#612
jiaqizho wants to merge 1 commit into
milvus-io:mainfrom
jiaqizho:refine-s3-crt-client-holder

Conversation

@jiaqizho

Copy link
Copy Markdown
Collaborator

No description provided.

@sre-ci-robot
sre-ci-robot requested review from sunby and tedxu July 31, 2026 10:19
@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiaqizho
To complete the pull request process, please assign shaoting-huang after the PR has been reviewed.
You can assign the PR to them by writing /assign @shaoting-huang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.45%. Comparing base (a95f6c0) to head (4d0ee0e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   75.99%   76.45%   +0.45%     
==========================================
  Files         170      173       +3     
  Lines       16960    17563     +603     
  Branches     2541     2654     +113     
==========================================
+ Hits        12889    13427     +538     
- Misses       4071     4136      +65     
Flag Coverage Δ
cpp 79.04% <100.00%> (+0.39%) ⬆️
python 44.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: jiaqizho <jiaqi.zhou@zilliz.com>
@jiaqizho
jiaqizho force-pushed the refine-s3-crt-client-holder branch from 5a65e19 to 4d0ee0e Compare August 13, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants