enhance:[2.6] classify packed extend status codes into segcore error codes (#575) - #578
Open
jiaqizho wants to merge 1 commit into
Open
enhance:[2.6] classify packed extend status codes into segcore error codes (#575)#578jiaqizho wants to merge 1 commit into
jiaqizho wants to merge 1 commit into
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiaqizho The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jiaqizho
force-pushed
the
2.6-cherry-pick-v2-errorcode
branch
from
July 7, 2026 03:56
1f9ae8c to
0da436d
Compare
…milvus-io#575) Add the producer-owned mapping `ToSegcoreErrorCode` / `ToSegcoreError` so milvus-storage classifies its own packed failures once, at the source, and milvus can consume a typed segcore `ErrorCode` instead of a generic Arrow status text. > Note: this **builds on milvus-io#572** (jiaqizho — packed `ExtendStatusCode` + `WrapExtendError`), which is not yet merged, so this branch currently includes those commits. Once milvus-io#572 lands this PR should be rebased onto it so it only carries the mapping delta. Happy to coordinate. | ExtendStatusCode | segcore ErrorCode | retry | |---|---|---| | PackedInvalidArgs | InvalidParameter (2042) | non-retriable (input) | | PackedStorageIO | **StorageTransientError (2045)** | **retriable** | | PackedMetadataCorrupted / PackedFileCorrupted | DataFormatBroken (2024) | permanent | | PackedArrowError / PackedUnexpected / AWS / Txn | StorageError (2044) | permanent | The retriable verdict is load-bearing: a transient storage IO failure maps to the retriable `StorageTransientError(2045)` and must never collapse into the non-retriable `StorageError(2044)`. The switch has no `default` + a post-switch fallback under `-Werror=switch`, so a new `ExtendStatusCode` breaks the build until classified. The no-detail path keeps a coarse arrow mapping (IO→transient, OOM→mem-allocate, Invalid/Type/Key→corruption). Depends on `milvus-common` `StorageTransientError(2045)`: zilliztech/milvus-common#102. Bump the `milvus-common` conan pin to the published 2045 revision before merge (the pin here points at a local build for verification). Design + tracking: milvus-io/milvus#50903. Consumed by milvus-io/milvus#50768. --------- Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com> Signed-off-by: jiaqizho <jiaqi.zhou@zilliz.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: jiaqizho <jiaqi.zhou@zilliz.com> (cherry picked from commit 9c28242) Signed-off-by: jiaqizho <jiaqi.zhou@zilliz.com>
jiaqizho
force-pushed
the
2.6-cherry-pick-v2-errorcode
branch
from
July 7, 2026 08:12
0da436d to
a0a7c16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the producer-owned mapping
ToSegcoreErrorCode/ToSegcoreErrorso milvus-storage classifies its own packed failures once, at the source, and milvus can consume a typed segcoreErrorCodeinstead of a generic Arrow status text.The retriable verdict is load-bearing: a transient storage IO failure maps to the retriable
StorageTransientError(2045)and must never collapse into the non-retriableStorageError(2044). The switch has nodefault+ a post-switch fallback under-Werror=switch, so a newExtendStatusCodebreaks the build until classified. The no-detail path keeps a coarse arrow mapping (IO→transient, OOM→mem-allocate, Invalid/Type/Key→corruption).Depends on
milvus-commonStorageTransientError(2045): zilliztech/milvus-common#102. Bump themilvus-commonconan pin to the published 2045 revision before merge (the pin here points at a local build for verification).Design + tracking: milvus-io/milvus#50903. Consumed by milvus-io/milvus#50768.
(cherry picked from commit 9c28242)