Skip to content

fix: honor --dstNodes in balance-segment #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sre-ci-robot merged 1 commit into from
Jul 27, 2026
Merged

fix: honor --dstNodes in balance-segment #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion states/mgrpc/querycoord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type BalanceSegmentParam struct {
CollectionID int64 `name:"collection" default:"0"`
SegmentIDs []int64 `name:"segment" desc:"segment ids to balance"`
SourceNodes []int64 `name:"srcNodes" desc:"from querynode ids"`
DstNodes int64 `name:"dstNode" desc:"to querynode ids"`
DstNodes []int64 `name:"dstNodes" desc:"to querynode ids, empty means let querycoord pick"`
}

func (s *queryCoordState) BalanceSegmentCommand(ctx context.Context, p *BalanceSegmentParam) error {
Expand All @@ -47,6 +47,8 @@ func (s *queryCoordState) BalanceSegmentCommand(ctx context.Context, p *BalanceS
CollectionID: p.CollectionID,
SealedSegmentIDs: p.SegmentIDs,
SourceNodeIDs: p.SourceNodes,
// Empty DstNodeIDs makes querycoord pick a target among all nodes of the replica.
DstNodeIDs: p.DstNodes,
}

resp, err := s.client.LoadBalance(ctx, req)
Expand Down
Loading