fix(system): fail loud on power-info read failure; balance README parens - #84
Merged
Merged
Conversation
system_power_info now returns None on RPC-level failure (timeout, non-OK, exception) so the tool raises ToolError instead of returning an empty power dict indistinguishable from a genuinely-empty result. Matches the fail-loud convention of the other system read tools. Closes #82. Closes #83. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review findings from the #79/#81 merges.
Changes
system_power_inforeturnsNoneon RPC-level failure (timeout, non-OK status, exception) instead of{}.flipperzero_system_power_infonow raisesToolError("power info unavailable")onNone, matching the fail-loud convention ofsystem_protobuf_version/system_datetime. A genuinely-empty result still returns{"power": {}}.## Status: balanced the parentheses around the read-tools list.Validation
uv run pytest -m "not integration" -q-> 134 passed, 2 deselecteduv run ruff check/ruff format --checkuv run ty check src/flipperzero_mcp/Closes #82.
Closes #83.
🤖 Generated with Claude Code