fix(firmware): confirm flash on (version, flavor) identity change - #114
Closed
millsmillsymills wants to merge 1 commit into
Closed
fix(firmware): confirm flash on (version, flavor) identity change#114millsmillsymills wants to merge 1 commit into
millsmillsymills wants to merge 1 commit into
Conversation
_reconnect_and_classify gated after_confirmed on version alone, so a same-version fork swap (Official <-> Momentum at a matching version) and a same-version recovery reflash reported as unconfirmed best-effort. Gate on the (version, flavor) identity and require a known baseline version, so a fork swap confirms; a same-version same-flavor reflash has no observable signal and stays best-effort. Closes #108 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by the rebased copy (same commit, rebased onto current phase1); see newer PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from review of #104.
_reconnect_and_classifygatedafter_confirmedonlast.version != before.version, so two genuine firmware changes reported as unconfirmed best-effort:Gate on the
(version, flavor)identity instead, and requirebefore.version is not Noneso the gate strictly means "observed a changed identity against a known baseline". A same-version, same-flavor reflash leaves no observable identity change indevice_info, so it honestly stays best-effort.Tests
test_reconnect_confirms_on_same_version_fork_swap— fork swap at one version confirms.test_reconnect_best_effort_on_same_version_same_flavor— no signal → best-effort.test_firmware_install_propagates_after_confirmed(parametrized) — tool-level wire contract:flipperzero_firmware_installpropagatesafter_confirmedinto the result dict.13 passed;
ty+ruffclean.Closes #108
🤖 Generated with Claude Code