Move opentiny to peer dependencies - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dependencies→peerDependencies(^6.9.0), and added it as adevDependency(^6.9.0) so the package can still build its own types.versionfrom5.1.0-rcto0.0.0(the real version is set from the git tag at publish time, so the committed value is meaningless).Why
opentinywas pinned exactly (6.9.33) in dependencies. In an app that also depends onopentinydirectly, a different patch version produced a duplicate, conflictingopentinyin the dependency tree. Since the wrapper uses opentiny only for TypeScript types (the editor is loaded at runtime from thewindow.tinymceglobal, never bundled), it should defer to the host app's copy.As a peer dependency with a
^6.9.0range, opentiny-react now binds to whateveropentinythe consuming app installs — one shared copy, no version conflicts — and we no longer need to bump this package for everyopentinypatch release.