Skip to content

MILAB-6690: align PlElementListItem head icons to top - #1794

Merged
AStaroverov merged 1 commit into
mainfrom
MILAB-6690_element-list-item-icons-top
Aug 24, 2026
Merged

MILAB-6690: align PlElementListItem head icons to top#1794
AStaroverov merged 1 commit into
mainfrom
MILAB-6690_element-list-item-icons-top

Conversation

@AStaroverov

@AStaroverov AStaroverov commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Wrap the drag handle and the expand chevron of PlElementListItem into a single .headIcons container and align it to the top of the head row (align-self: flex-start, fixed 24px height).

Previously both icons were direct children of the vertically-centered head, so with a multiline title they drifted to the vertical middle. Now they stay on the first line of the title.

Greptile Summary

This PR updates PlElementListItem so its drag handle and expansion chevron remain aligned with the top of the head row for multiline titles, and records the UIKit patch release.

  • PlElementListItem — a UIKit list-row component supporting titles, expandable content, drag handles, and row actions. Its leading icons are now grouped inside a top-aligned headIcons container.
  • headIcons — the new flex container around the drag handle and expansion chevron. It has a fixed 24px height and opts out of vertical centering with align-self: flex-start.
  • Drag handle — the drag-dots control used to initiate sortable interaction. Its selector and data-draggable contract remain unchanged inside the new container.
  • Expansion chevron — the icon indicating collapsed or expanded content. Its rotation and expansion behavior remain unchanged while its layout ancestry changes.
  • Changeset — release metadata consumed by the monorepo publishing workflow. It declares a patch release for @milaboratories/uikit.

Confidence Score: 5/5

The PR appears safe to merge because the change is presentational and preserves existing drag, expansion, and event contracts.

The new wrapper keeps the sortable handle attribute and expansion behavior on the same elements, while its dimensions accommodate the existing 24px action and 16px chevron without clipping.

Important Files Changed

Filename Overview
lib/ui/uikit/src/components/PlElementList/PlElementListItem.vue Groups the existing leading icons in a 24px top-aligned flex container without changing their selectors, events, or conditional rendering.
.changeset/element-list-item-icons-top.md Correctly records the user-visible layout adjustment as a UIKit patch release.

Reviews (1): Last reviewed commit: "MILAB-6690: align PlElementListItem head..." | Re-trigger Greptile

Context used:

  • Context used - Terms is a types in codebase. Provide the list of ... (source)

@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fdca274

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@milaboratories/uikit Patch
@platforma-sdk/ui-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@notion-workspace

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.10%. Comparing base (1f6ec78) to head (fdca274).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
+ Coverage   53.07%   53.10%   +0.03%     
==========================================
  Files         414      414              
  Lines       21347    21347              
  Branches     4762     4762              
==========================================
+ Hits        11329    11336       +7     
+ Misses       8658     8654       -4     
+ Partials     1360     1357       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AStaroverov
AStaroverov added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit 47c6e22 Aug 24, 2026
15 checks passed
@AStaroverov
AStaroverov deleted the MILAB-6690_element-list-item-icons-top branch August 24, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants