MILAB-6690: align PlElementListItem head icons to top - #1794
Merged
Conversation
🦋 Changeset detectedLatest commit: fdca274 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
==========================================
+ Coverage 53.07% 53.10% +0.03%
==========================================
Files 414 414
Lines 21347 21347
Branches 4762 4762
==========================================
+ Hits 11329 11336 +7
+ Misses 8658 8654 -4
+ Partials 1360 1357 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kevindetry-milaboratories
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the drag handle and the expand chevron of
PlElementListIteminto a single.headIconscontainer and align it to the top of the head row (align-self: flex-start, fixed24pxheight).Previously both icons were direct children of the vertically-centered head, so with a multiline title they drifted to the vertical middle. Now they stay on the first line of the title.
Greptile Summary
This PR updates
PlElementListItemso its drag handle and expansion chevron remain aligned with the top of the head row for multiline titles, and records the UIKit patch release.headIconscontainer.align-self: flex-start.drag-dotscontrol used to initiate sortable interaction. Its selector anddata-draggablecontract remain unchanged inside the new container.@milaboratories/uikit.Confidence Score: 5/5
The PR appears safe to merge because the change is presentational and preserves existing drag, expansion, and event contracts.
The new wrapper keeps the sortable handle attribute and expansion behavior on the same elements, while its dimensions accommodate the existing 24px action and 16px chevron without clipping.
Important Files Changed
Reviews (1): Last reviewed commit: "MILAB-6690: align PlElementListItem head..." | Re-trigger Greptile
Context used: