Skip to content

Transparency support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxschmeling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transparency support #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ccc1af
Updated to PNG image stream and libvpx video codec.
maxschmeling Dec 6, 2016
6ed94df
Returning Promise for FFmpeg process close from end method.
maxschmeling Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ function createMovieRecorderStream (win, options_) {
'-y',
'-f', 'image2pipe',
'-r', '' + (+fps),
// we use jpeg here because the most common version of ffmpeg (the one
// that ships with homebrew) is broken and crashes when you feed it PNG data
// https://trac.ffmpeg.org/ticket/1272
'-vcodec', 'mjpeg',
'-i', '-'
'-i', '-',
'-c:v', 'libvpx',
'-auto-alt-ref', '0',
'-pix_fmt', 'yuva420p',
'-metadata:s:v:0', 'alpha_mode="1"'
]

var outFile = options.output
Expand All @@ -38,6 +38,7 @@ function createMovieRecorderStream (win, options_) {
}

var ffmpeg = spawn(ffmpegPath, args)
var ffmpegClosePromise = new Promise(resolve => ffmpeg.on('close', resolve))

function appendFrame (next) {
// This is dumb, but sometimes electron's capture fails silently and returns
Expand All @@ -46,11 +47,12 @@ function createMovieRecorderStream (win, options_) {
function tryCapture () {
try {
win.capturePage(function (image) {
var jpeg = image.toJpeg(100)
if (jpeg.length === 0) {
var png = image.toPNG()

if (png.length === 0) {
setTimeout(tryCapture, 10)
} else {
ffmpeg.stdin.write(jpeg, function (err) {
ffmpeg.stdin.write(png, function (err) {
next(err)
})
}
Expand All @@ -64,6 +66,7 @@ function createMovieRecorderStream (win, options_) {

function endMovie () {
ffmpeg.stdin.end()
return ffmpegClosePromise
}

var result = {
Expand Down