Add label parsing - #8
Open
ThePokeX wants to merge 11 commits into
Open
Conversation
added 11 commits
November 17, 2017 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind this change is to allow automation to create easy to find and useful info/links about containers.
A use case would be if you wanted to automatically generate a link to the container's log file, you could assign the label
swarm-viz.link.log=https://log.storage.site/${imagename}/${containerid}to a service and easily find the log location when looking at the details of any container belonging to the service.This is particularly useful in large swarms with lots of container replication.
Any labels that were parsed will be shown at the top of the detailed info screen, but if no labels start with
swarm-viz.then the section will not render, leaving the page looking exactly how it is now.