fix: deep code review pass 35 - 6 issues fixed - #281
Merged
Conversation
- Reject flowsets with header.length < 4 in IPFIX and V9 pending flow caching (saturating_sub produced 0, bypassing truncation check) - Reconcile IPFIX header.length from remaining flowsets after caching (prevents drift from saturating arithmetic on corrupt input) - Add debug_assert for I24/U24 value range in serialization - Add Ord derive to ApplicationId for consistency with other field types - Replace ~20 vacuous `let _ = parser.parse_bytes()` in tests with assertions verifying parse success (template_cache, cache_collision, memory_bounds, template_hooks) - Tighten PCAP integration test assertions from `> 0` to exact values (6666 packets, 17 cache entries, 5754 hits, 901 misses)
… migrate from Remove 8 items that were deprecated in the same version they shipped: - `crate::field_types` module (use `variable_versions::field_types`) - `crate::template_events` module (use `variable_versions::template_events`) - `NetflowParserBuilder::multi_source()` (use `try_multi_source()`) - `RouterScopedParser::with_builder()` (use `try_with_builder()`) - `AutoScopedParser::with_builder()` (use `try_with_builder()`) - `variable_versions::data_number` module (use `variable_versions::field_value`) - `IpFixFlowRecord` type alias (use `IPFixFlowRecord`) - `FieldValue::Unknown` variant (use `FieldValue::Vec`) Update RELEASES.md to reflect removals instead of deprecations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let _ = parser.parse_bytes()in tests with assertions verifying parse success (template_cache, cache_collision, memory_bounds, template_hooks)> 0to exact values (6666 packets, 17 cache entries, 5754 hits, 901 misses)