fix: deep code review pass 34 - 3 issues fixed - #280
Merged
Conversation
mikemiles-dev
commented
Mar 15, 2026
mikemiles-dev
commented
Owner
- Data::with_template_field_lengths() returns Result instead of panicking via assert_eq! (public API should never panic on invalid input)
- OptionsData::with_template_field_lengths() same treatment for consistency
- Data::new() adds debug_assert catching variable-length field misuse
- Remove unreachable template_size==0 dead code in IPFIX parse_inner
- Data::with_template_field_lengths() returns Result instead of panicking via assert_eq! (public API should never panic on invalid input) - OptionsData::with_template_field_lengths() same treatment for consistency - Data::new() adds debug_assert catching variable-length field misuse - Remove unreachable template_size==0 dead code in IPFIX parse_inner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.