fix: deep code review pass 33 - 6 issues fixed - #279
Merged
Conversation
mikemiles-dev
commented
Mar 15, 2026
mikemiles-dev
commented
Owner
- V9 lookup test coverage extended from 1..=282 to 1..=323 (41 untested field IDs)
- Enterprise bit extraction uses bitmask (& 0x7FFF) instead of overflowing_sub per RFC 7011
- Data::with_template_field_lengths validates field count matches record length
- TcpControlBits serialization uses explicit mask (val & 0xFF) instead of silent truncation
- RELEASES.md: V9 field count corrected from 46 to 48
- RELEASES.md: added missing InvalidPendingTotalBytes ConfigError variant
- V9 lookup test coverage extended from 1..=282 to 1..=323 (41 untested field IDs) - Enterprise bit extraction uses bitmask (& 0x7FFF) instead of overflowing_sub per RFC 7011 - Data::with_template_field_lengths validates field count matches record length - TcpControlBits serialization uses explicit mask (val & 0xFF) instead of silent truncation - RELEASES.md: V9 field count corrected from 46 to 48 - RELEASES.md: added missing InvalidPendingTotalBytes ConfigError variant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.