fix: deep code review passes 25-28 - 18 issues fixed - #276
Merged
Conversation
Pass 25 (6 fixes): - IPFIX V9 options template validation aligned with V9 parser (reject individual zero-length fields) - would_accept() false negative causing data truncation fixed - set_pending_flows_config(None) now records dropped metrics - IPFIX replay flowset count bound added (consistent with V9) - YAF DnsSRVTarget (219) type corrected to String - YAF SslPublicKeyLength (250) type corrected to UnsignedDataNumber Pass 26 (3 fixes): - IPFIX "withdraw all" templates implemented per RFC 7011 §8.1 - V9 replay flowset limit uses break instead of continue - IPFIX withdrawal+redefinition in same flowset no longer drains pending flows Pass 27 (3 fixes): - Fuzz round-trip target uses fresh parser for re-parse (no accumulated state) - README: 3 missing examples added - Redundant test renamed to test_v5_serialization_single_packet Pass 28 (3 fixes): - IPFIX withdraw-all now drains only same-type pending flows (not cross-type) - test_pcap_iterator_api now only counts successful parses - README v0.7.0 breaking change note updated for v1.0.0 Additional improvements: - Dead macro parameter removed from impl_try_from! - TemplateHooks::clear() method added - test_parser_builder_with_field_count_limits made non-vacuous - test_parser_builder_comprehensive strengthened with functional verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass 25 (6 fixes):
Pass 26 (3 fixes):
Pass 27 (3 fixes):
Pass 28 (3 fixes):
Additional improvements: