fix: deep code review pass 23 - Clone bound, IPFIX duplicate check, D… - #274
Merged
Conversation
…isplay tests - Remove unnecessary K: Clone bound from RouterScopedParser::all_stats() - Fix IPFIX OptionsTemplate duplicate checking to validate scope and option fields separately per RFC 7011 (consistent with V9) - Add Display test coverage for 8 field types: FragmentFlags, Ipv4Options, Ipv6ExtensionHeaders, IsMulticast, TcpOptions, MplsLabelExp, NatOriginatingAddressRealm, MplsTopLabelType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…isplay tests