fix: deep code review passes 19-20 - API hardening, test coverage, an… - #271
Merged
Conversation
…d correctness fixes Pass 19: - clear_v9_templates/clear_ipfix_templates now also clear pending flows - V9/IPFIX template validation rejects field_length=0 - Deduplicate validate_config (delegate to Config::validate) - Strengthen 5 malformed-input test assertions - Remove 7 vacuous initial-state tests - Add round-trip tests: DurationMicrosNTP, DurationNanosNTP, U128, I128, U24, enterprise fields, multi-template flowset - Add concurrent V9 template test and template collision data verification Pass 20: - Add #[non_exhaustive] to 9 public types (NetflowError, ConfigError, FieldValue, Config, PendingFlowsConfig, CacheStats, ParserCacheStats, CacheMetricsSnapshot, NoTemplateInfo) - Remove dead MissingTemplate error variant - Add root re-exports: FieldValue, DataNumber, FieldDataType, V9Field, V9FieldPair, V9FlowRecord - InvalidErrorSampleSize/InvalidMaxSources now carry the rejected value - CacheMetrics mutation methods scoped to pub(crate), dead reset() removed - resize() now validates full PendingFlowsConfig - README: fix error type list (removed MissingTemplate, added FilteredVersion), fix URP->UDP typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d correctness fixes
Pass 19:
Pass 20: