061 ipfix lookup cleanup - #145
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up IPFIX lookup fields by replacing generic AssignedforNetFlowv9compatibility and Unknown entries with explicit field names and indices, and updates snapshots/tests and release notes accordingly.
- Updated variable version snapshots to include new numbered compatibility entries.
- Refreshed test snapshots to map Cisco enterprise fields to named variants and correct data numbers.
- Added a release note for the fix.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/variable_versions/snapshots/netflow_parser__...__ipfix_lookup__it_tests_field_lookup.snap | Added explicit AssignedforNetFlowv9compatibilityXX entries. |
| src/variable_versions/snapshots/netflow_parser__...__field_data_type_lookup.snap | Added explicit data type mappings (UnsignedDataNumber, Ip4Addr). |
| src/snapshots/netflow_parser__tests__base_tests__ipfix.snap | Updated Cisco enterprise field mappings in test snapshots. |
| RELEASES.md | Added a bullet for the IPFIX lookup field fix. |
Comments suppressed due to low confidence (1)
RELEASES.md:5
- Add a new release heading (e.g.,
# 0.6.1) above this bullet to clearly denote this has been released, keeping consistency with existing versioning format.
* Fixed issue with certain ipfix lookup fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.