[codex] resolve beta.1 audit advisories - #47
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project to version 2.0.0-beta.1, introducing new editor features such as autosave/restore and material duplication, and updating several dependencies to resolve security advisories. The reviewer provided feedback on scoping the brace-expansion dependency override to prevent compatibility issues with packages requiring version 2.x, reorganizing the changelog to distinguish new features from maintenance updates, and removing the now-redundant @types/uuid package.
| "qs": "^6.14.1", | ||
| "jsonpath": "^1.2.1", | ||
| "brace-expansion": "^1.1.12" | ||
| "brace-expansion": "^1.1.14" |
There was a problem hiding this comment.
This global override forces brace-expansion to version 1.x for the entire dependency tree. However, the project also uses minimatch 9.0.9 (via typescript-eslint), which depends on brace-expansion ^2.0.2. Forcing a major version downgrade on packages that expect the 2.x API can lead to runtime errors or unexpected behavior in development tools. Since brace-expansion 1.1.11+ already addresses the security concerns for the 1.x branch, consider scoping this override to only affect packages that require the 1.x line.
| "brace-expansion": "^1.1.14" | |
| "minimatch@<5": { "brace-expansion": "^1.1.14" } |
| ### Maintenance | ||
|
|
||
| - Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export. | ||
| - Added concise Power Tools tooltips for better in-editor discoverability. | ||
| - Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories. |
There was a problem hiding this comment.
The new entries for version 2.0.0-beta.1 include significant feature additions (e.g., autosave/restore, material duplication, tooltips) but are currently grouped under ### Maintenance. It is better to use standard categories like ### Added for user-facing features and keep ### Maintenance for internal updates like dependency bumps. This improves the readability and discoverability of changes for users.
| ### Maintenance | |
| - Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export. | |
| - Added concise Power Tools tooltips for better in-editor discoverability. | |
| - Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories. | |
| ### Added | |
| - Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export. | |
| - Added concise Power Tools tooltips for better in-editor discoverability. | |
| ### Maintenance | |
| - Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories. |
| "tailwindcss": "^4.1.18", | ||
| "three": "^0.182.0", | ||
| "uuid": "^13.0.0", | ||
| "uuid": "^13.0.2", |
There was a problem hiding this comment.
Summary
2.0.0-beta.1so it matches the README release notes.2.0.0-beta.1changelog entry.Validation
npm run quality:cinpm run test:cinpm run buildnpm run check:bundlenpm run security:auditnpm run test:e2eNote: the first e2e run only failed because the matching local Playwright Chromium binary was missing; after
npx playwright install chromium, all 19 e2e tests passed.