Skip to content

[codex] resolve beta.1 audit advisories - #47

Merged
mikechaves merged 2 commits into
mainfrom
mike/security-audit-beta1
May 23, 2026
Merged

[codex] resolve beta.1 audit advisories#47
mikechaves merged 2 commits into
mainfrom
mike/security-audit-beta1

Conversation

@mikechaves

Copy link
Copy Markdown
Owner

Summary

  • Bump the package metadata to 2.0.0-beta.1 so it matches the README release notes.
  • Refresh the lockfile and direct dependency minimums for the current npm audit advisories.
  • Add the missing 2.0.0-beta.1 changelog entry.

Validation

  • npm run quality:ci
  • npm run test:ci
  • npm run build
  • npm run check:bundle
  • npm run security:audit
  • npm run test:e2e

Note: the first e2e run only failed because the matching local Playwright Chromium binary was missing; after npx playwright install chromium, all 19 e2e tests passed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to version 2.0.0-beta.1, introducing new editor features such as autosave/restore and material duplication, and updating several dependencies to resolve security advisories. The reviewer provided feedback on scoping the brace-expansion dependency override to prevent compatibility issues with packages requiring version 2.x, reorganizing the changelog to distinguish new features from maintenance updates, and removing the now-redundant @types/uuid package.

Comment thread package.json Outdated
"qs": "^6.14.1",
"jsonpath": "^1.2.1",
"brace-expansion": "^1.1.12"
"brace-expansion": "^1.1.14"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This global override forces brace-expansion to version 1.x for the entire dependency tree. However, the project also uses minimatch 9.0.9 (via typescript-eslint), which depends on brace-expansion ^2.0.2. Forcing a major version downgrade on packages that expect the 2.x API can lead to runtime errors or unexpected behavior in development tools. Since brace-expansion 1.1.11+ already addresses the security concerns for the 1.x branch, consider scoping this override to only affect packages that require the 1.x line.

Suggested change
"brace-expansion": "^1.1.14"
"minimatch@<5": { "brace-expansion": "^1.1.14" }

Comment thread CHANGELOG.md Outdated
Comment on lines +7 to +11
### Maintenance

- Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export.
- Added concise Power Tools tooltips for better in-editor discoverability.
- Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new entries for version 2.0.0-beta.1 include significant feature additions (e.g., autosave/restore, material duplication, tooltips) but are currently grouped under ### Maintenance. It is better to use standard categories like ### Added for user-facing features and keep ### Maintenance for internal updates like dependency bumps. This improves the readability and discoverability of changes for users.

Suggested change
### Maintenance
- Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export.
- Added concise Power Tools tooltips for better in-editor discoverability.
- Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories.
### Added
- Added rapid-iteration editor tooling for draft autosave/restore, material duplication, randomization, texture clearing, and draft JSON import/export.
- Added concise Power Tools tooltips for better in-editor discoverability.
### Maintenance
- Updated dependency lockfile and direct dependency minimums to resolve current npm audit advisories.

Comment thread package.json
"tailwindcss": "^4.1.18",
"three": "^0.182.0",
"uuid": "^13.0.0",
"uuid": "^13.0.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The uuid package is updated to ^13.0.2. Note that uuid version 11 and higher includes built-in TypeScript definitions. You should consider removing the redundant @types/uuid dependency (currently at ^9.0.8 on line 74) to avoid potential type conflicts and reduce maintenance overhead.

@mikechaves
mikechaves marked this pull request as ready for review May 23, 2026 00:33
@mikechaves
mikechaves merged commit f0e00a5 into main May 23, 2026
2 checks passed
@mikechaves
mikechaves deleted the mike/security-audit-beta1 branch May 23, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant