fix: replace ember assign with Object.assign - #617
Open
tsmalls93 wants to merge 2 commits into
Open
Conversation
aceol
approved these changes
Oct 25, 2023
aceol
left a comment
There was a problem hiding this comment.
🙌🏻 Would be great to have this. Lots of warnings will popup with ember-data update (and it'll broke in v5).
If possible, change also this ligne in the readme:
payload.data.attributes = assign(payload.data.attributes, attributes);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember assign has been deprecated in this RFC and @ember/polyfills is no longer available in Ember 5.x.