Skip to content

fix: url with query params - #506

Open
mrloop wants to merge 1 commit into
mike-north:masterfrom
mrloop:em-query-params
Open

fix: url with query params#506
mrloop wants to merge 1 commit into
mike-north:masterfrom
mrloop:em-query-params

Conversation

@mrloop

@mrloop mrloop commented Mar 12, 2021

Copy link
Copy Markdown

This PR will correctly construct a URL where the ember-api-action path
contains query params and/or where the ember data adapter buildURL
returns a url containing query params.

Fixes #414

@mrloop
mrloop force-pushed the em-query-params branch 2 times, most recently from 6315e27 to 7bbf27a Compare March 22, 2021 19:40
@mrloop mrloop mentioned this pull request Mar 22, 2021
@sandstrom

Copy link
Copy Markdown

friendly ping @mike-north @Turbo87 @alexlafroscia

This PR will correctly construct a URL where the ember-api-action path
contains query params and/or where the ember data adapter buildURL
returns a url containing query params.

Fixes mike-north#414
@mrloop
mrloop force-pushed the em-query-params branch 2 times, most recently from 8c81fc3 to c551166 Compare July 9, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Url is not build properly when there is a query params in the adapter buildUrl method.

2 participants