Handling cases where jsonapi.version isn't set

[krainboltgreene]

#291 is a problem for anyone using the ruby library jsonapi-resources, as it both doesn't support returning /jsonapi/version and it is very annoying to hack in.

I prefer to trust but warn, but failing that I've at least checked for a data attribute.

[ghost]

There were the following issues with this Pull Request

• Commit: 1069ff1
  • ✖ message may not be empty
  • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[krainboltgreene]

Maybe I don't understand typescript, but why isn't the return type boolean?

[krainboltgreene]

What is commitlint talking about here?

[ghost]

There were the following issues with this Pull Request

• Commit: 1069ff1
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: d1c85c9
  • ✖ message may not be empty
  • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[ghost]

There were the following issues with this Pull Request

• Commit: 1069ff1
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: d1c85c9
  • ✖ message may not be empty
  • ✖ type may not be empty
• Commit: e44f9e8
  • ✖ message may not be empty
  • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[thec0keman]

Shouldn't this be doc.data?

[jagthedrummer]

Anything we can do to get this merged? I just ran into this and am trying to work around it like so, but with no luck.

    after(response){
      response.jsonapi = { "version": "1.0" };
      serializeAndPush(this, response);
    }

I'm still getting the console message:

serializeAndPush may only be used with a JSON API document. Ignoring response. Document must have a mandatory JSON API object. See https://jsonapi.org/format/#document-jsonapi-object.

[dbollinger]

@jagthedrummer I was running into friction here as well (literally yesterday) -- in the short term, so that I could start using this add-on, I just created my own (very brittle) method:

export default function serializeAndPushRecord(payload) {
  let serializer = this.store.serializerFor(payload.data.type);
  serializer.pushPayload(this.store, payload);
}

YMMV, and I only need this for single members (not collections) right now, but if you're looking for a quick answer while this addon goes through some modernization and maintenance, something like this could be an option.