feat(cli-mode): make CLI/tmux agent 'working right now' legible in web UI (animated, is_running-driven)#44
Merged
Conversation
…) driven by live is_running
…aced by cliAgentWorking)
…educed-motion guard on RunningDots
miguelrisero
marked this pull request as ready for review
July 23, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In web ("UIX"/CLI) mode, when a CLI/tmux-driven
claudeagent is actively working, the UI didn't make it legible — the in-view indicator was a static, mislabeledCircleIcondot reading "CLI session active". It read like a passive presence LED, not "the agent is working right now". (Owner: "you don't know when the agent is doing/processing. that's not good.")Approach — reuse the existing live signal, animate the render
The live signal already exists end-to-end and needed no backend/schema change: the
cli_activitypoller setsstate='running'when the tmuxclaudepane emits output within a 5s window (ACTIVE_WINDOW_SECS,crates/local-deployment/src/cli_activity.rs) → SQLis_running(crates/db/src/models/workspace.rs) → the frontend already computescliSessionActive = isRunning && !isExecutorRunning(WorkspacesLayout.tsx), which flips false ~5s after output stops. This PR only fixes the rendering inside that already-correct gate.What changed (frontend-only, additive)
ConversationListContainer.tsx): staticCircleIcon→ animated<RunningDots/>(the app's canonical "running" animation, same component the sidebarWorkspaceSummaryuses), copy → newconversation.cliAgentWorking("Agent working…"). The{cliSessionActive && …}gate is unchanged, so it animates only while producing output and vanishes within ~5s of silence.CliMainPane.tsx+ bothWorkspacesLayout.tsxcall sites): newcliRunning={cliSessionActive}prop drives a compact header chip — a spinningCircleNotchIcon+cliMode.working("Working…") when running, a quiet dot +cliMode.idle("Idle") otherwise. Gated onsessionsReady && !executorRunningso it never hides the live terminal nor contradicts the executor full-screen notice. Label is icon-only on mobile.conversation.cliAgentWorking,cliMode.working,cliMode.idleand removed the now-supersededconversation.cliSessionActiveacross all 7 locales (en/es/fr/ja/ko/zh-Hans/zh-Hant).The one correctness point
The animation is driven by the live
is_runningflip (off ~5s after output stops), not by "a CLI session exists" — an always-pulsing indicator would be as useless as the old static dot. The{cliSessionActive && …}gate andcliRunning={cliSessionActive}derivation preserve this. Proven live (see below): both the ON and the OFF transition.Deliberate design calls
motion-reduce:animate-noneguard was added to it (it was previously missing across all ~6 of its usages) so reduced-motion users are respected — meaning is also carried by therole="status"text label.aria-hidden): the canonical announced status is the sidebar<Badge role="status">(announces once, unmounts on idle — no chatter); the chip is a redundant visual mirror, so marking itaria-hiddenavoids screen-reader chatter on every flip and an empty live-region on mobile. (From the review gauntlet.)STRETCH — not done (intentional)
The optional "derive an actively-emitting boolean from patch-arrival cadence in the stream hooks" was skipped: it's more than a small addition (new state/timers + plumbing in
useJsonPatchWsStream/useSessionNativeFeed), so per the brief it's left to the design doc rather than gold-plated here.Verification
Static (all green):
tsc(web-core/ui/local-web/remote-web) · eslint (max-warnings 0) ·check-i18n.sh(dup-keys + cross-locale parity + literal-strings) · unused-i18n-key checker · vitest (224 passed) · CI-exactcargo clippy --workspace --all-targets --exclude vibe-kanban-tauri -- -D warnings·cargo test --workspace.Live e2e on a scratch dev stack (decisive — both transitions proven on-screen): drove a real CLI/tmux
claudeagent and captured, for both surfaces:is_running, not session-existence).Review gauntlet (proportional to a ~79-line additive change)
min-w-0removed; CircleNotch-vs-RunningDots is a deliberate keep).Risk: LOW (additive UI, no schema, no dispatch paths). Opened as DRAFT for boss verification. Note: shares
ConversationListContainer.tsxregion-wise and the 7common.jsonfiles with concurrent Lane M — kept to distinct i18n keys; rebase onto M then re-verify before flipping to ready.