[codex] Fix release gate parity lanes - #473
Merged
Merged
Conversation
There was a problem hiding this comment.
APPROVE
요약
Blocking issue 없이 승인합니다. 이 PR은 0.1.9 release-candidate strict Official Suite run에서 발견된 10개 deterministic mismatch를 해결하는 bugfix입니다.
주요 변경 사항
1. Insert _id 자동 할당 (InMemoryCollectionStore.java:141-145)
_id필드가 없는 문서에ObjectId자동 생성하여 MongoDB insert parity 반영- Immutable copy 패턴 유지 (source 문서는 수정되지 않음)
- Unit test 추가로 동작 검증
2. Release-gate lane gating (UnifiedSpecImporter.java)
mongos-unpin경로를 topology lane override에서 제외client-bulkWrite-errors경로를 version gate에 추가- 두 변경 모두 conservative: unsupported feature가 supported로 노출되는 것을 방지
판단 근거
- Correctness:
_id자동 생성은 MongoDB 표준 동작에 부합 - Safety: Lane gating 변경은 더 엄격한 기준을 적용 (feature exposure 축소)
- Test coverage: 새 동작에 대한 unit test 존재
- Documentation: CHANGELOG.md 업데이트 포함
Reviewed by Z.ai GLM via Claude Code Action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectIdvalues when inserts omit_id, matching MongoDB insert behavior for runtime usersmongos-unpintopology-gated until generated ObjectId differential comparison is explicitly handledclient-bulkWrite-errors*version-gated until its error contract is implementedWhy
The 0.1.9 release-candidate strict Official Suite run found 10 deterministic mismatches: 4 from
mongos-unpingenerated_idcomparison and 6 fromclient-bulkWrite-errors*suites being admitted by an overly broad lane.Validation
.tooling/gradle-8.10.2/bin/gradle test --tests org.jongodb.engine.InMemoryCollectionStoreTest --tests org.jongodb.testkit.UnifiedSpecImporterTest --tests org.jongodb.engine.AggregationPipelineTest.tooling/gradle-8.10.2/bin/gradle test --tests org.jongodb.engine.InMemoryCollectionStoreTest --tests org.jongodb.testkit.UnifiedSpecImporterTestgit diff --check.tooling/gradle-8.10.2/bin/gradle clean testCloses #472