docs(desktop): cite upstream wails#6047 next to the webview-peer shim - #75
Merged
Conversation
normalizeWebviewPeer works around the wails asset server stamping a non-loopback TEST-NET peer on webview requests. The upstream fix is now proposed at wailsapp/wails#6047; note it so the shim's clear can be dropped once a pinned wails version carries a loopback peer. Comment-only. GDK-918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. Adds a pointer from
normalizeWebviewPeer(desktop/main.go) to the upstream fix I opened at wailsapp/wails#6047, so the downstream shim'sRemoteAddrclear can be dropped once a pinned wails version synthesizes a loopback peer. Touchesdesktop/, so it takes the PR route for the Desktop build jobs. GDK-918.