Remove dead code, fix gofmt drift, and gate formatting in CI - #66
Merged
Conversation
subscriptionTotal had no callers; subscriptionLineAmounts is the only path in use. The gofmt changes are alignment-only drift accumulated across recent rounds, made visible now that CI checks formatting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Nothing enforced formatting, so drift accumulated silently across twelve files. The step runs before the test suite so a fmt-only failure surfaces fast. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No product behaviour changes — repository hygiene only.
subscriptionTotal, a caller-less wrapper aroundsubscriptionLineAmounts.gofmtto twelve files. The diff is alignment-only (varblock padding, onep.has(prefix+"…")spacing).gofmt -lstep to CI, ahead of the test suite. Nothing enforced formatting before, which is how the drift accumulated silently.Verification
go build ./...,go vet ./...— passgo test ./...— pass, no failuresimported=50 skipped=1 unsupported=1 mismatch=0 error=09900/10890,total_taxesshape, test-clock renewal tax990, discount-then-tax7425/743/8168, fixturetxr_vat10preservation, promo apply/remove, upcoming preview4900/490/5390,automatic_tax↔default_tax_ratesmutual exclusion) — all passgofmt -lreturns nothing;go list -deps ./cmd/billtap | grep -c testingreturns 0🤖 Generated with Claude Code