Repository navigation
ci: pass the inbox hub settings to the backend-pn Playwright app - #16
Merged
Merged
Conversation
The new backend-configuration inbox spec signs its hub calls with a CI-only key and serves a stub hub on the runner. Start the app with the same signing key, hub URL and host-gateway mapping as the plugin's own workflows; without a key every signed hub call is refused (401). closes #15 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change matches the plugin’s CI configuration and test constants.
Review effort: Balanced
Findings: None
What changed in this PR
Configures the backend Playwright container so inbox hub tests can authenticate and reach the runner-hosted stub.
Changes:
- Adds the host gateway, CI signing key, and stub hub URL to the backend Playwright app container.
| File | Description |
|---|---|
.github/workflows/dotnet-core-docker.yml |
Supplies inbox hub settings to the backend Playwright container. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
Run 37216811181 (v10.0.285):
backend-pn-playwright-test (i)failed on every attempt withSigned hub call catalog (GET /api/backend-configuration-pn/inbox/hub/catalog) failed: HTTP 401ininbox.spec.ts's beforeAll.The inbox spec (microting/eform-backendconfiguration-plugin#1407) signs its hub calls with the CI-only key
CI_INBOX_SIGNING_KEYand starts a stub hub on port 4399 on the runner. The plugin's own workflows start the app with the matching settings; this job did not, so the app had no signing key and refused every call, as designed.This adds the same three flags as the plugin's
dotnet-core-pr.yml, only tobackend-pn-playwright-test's app start:--add-host=host.docker.internal:host-gateway -e InboundMailHub__TenantSigningKey=… -e InboundMailHub__HubUrl=http://host.docker.internal:4399The key is CI-only and must be known to the spec, so it is not a secret. Other shards see "hub unavailable" in Indbakke settings, as in the plugin's CI. No product change; users are unaffected.
Verification: YAML parses; only that job's
docker runchanged; values match the plugin workflow and the spec byte for byte. This workflow runs only on tags, so the next tag is the real test.🤖 Generated with Claude Code