Repository navigation
ci: run SentryDsnAssemblyMetadataTests in the timeplanning dotnet shards - #12
Merged
Merged
Conversation
The timeplanning plugin added the class to shard a of its own workflows (eform-angular-timeplanning-plugin#1738). The container matrix lists classes explicitly, so add it to shard a here too. closes #11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The filter correctly targets the existing test class and is passed to the intended test project.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the missing Sentry DSN metadata test to the TimePlanning .NET CI matrix.
Changes:
- Adds
SentryDsnAssemblyMetadataTeststo sharda. - Matches the class namespace on the plugin’s
stablebranch.
| File | Description |
|---|---|
.github/workflows/dotnet-core-docker.yml |
Includes the Sentry metadata test in the shard filter. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
microting/eform-angular-timeplanning-plugin#1738 added
TimePlanning.Pn.Test.SentryDsnAssemblyMetadataTeststo shardaof the plugin repo's workflows. Thetimeplanning-pn-dotnet-testmatrix here lists classes explicitly, so the class never ran in this pipeline. This adds it to sharda.The test is a single reflection check on the plugin assembly's
SentryDsnmetadata and needs no database.Verified: YAML parses; the class and namespace match the plugin's merged
stable; the job checks out the plugin atstableand passes the shard filter todotnet test.Note, not changed here: this matrix lists 33 of the plugin repo's 87 test classes; 54 classes never run in this pipeline.
🤖 Generated with Claude Code