Skip to content

Kemi: dialogs give no feedback when the host interceptor ends a save with no answer #1465

Open

Description

@renemadsen

What is wrong

The Kemi dialogs have no error: callback on purpose: the host HttpErrorInterceptor ends a 5xx or network failure with EMPTY after its retries, so a callback would be dead code. The result is a silent no-answer on an outage: the dialog frees its busy state (closeWhenSaved) and ChemicalLatestLoad covers the loads, but the user gets no toast from a save that never answered.

Where (stable a81a41b)

The six W2/W3 dialogs and closeWhenSaved in eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-dialogs.helper.ts.

Suggested fix

A shared defaultIfEmpty-style "no answer" helper that toasts a fixed localized text and frees the dialog. This is tied to the host HttpErrorInterceptor issue (retry and EMPTY handling in eform-angular-frontend); decide the shape together with that fix.

Origin

Plan E T13 ruling, carried by the final review (§4, parked row), PR #1437 (merged as a81a41b).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions