Skip to content

Kemi: safety data sheet open leaks its blob URL and can be popup-blocked #1464

Open

Description

@renemadsen

What is wrong

openSafetyDataSheet has three weaknesses left after the Copilot fix for the empty-completion toast: (1) the object URL from URL.createObjectURL is never revoked, so every opened sheet leaks a blob until the page unloads; (2) window.open is called after an async request, so a popup blocker can swallow it with no feedback; (3) the shared host-interceptor behaviour (EMPTY after retries) is only handled for this one call.

Where (stable a81a41b)

eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-dialogs.helper.ts:94-113

Suggested fix

Revoke the URL after a delay or on the opened window's load. Open the tab synchronously on click and set its location when the blob arrives (or toast when window.open returns null).

Origin

Plan E final review m-10, PR #1437 (merged as a81a41b); partly fixed by Copilot round 1 (67a8b2a).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions