You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Kemi: share one vector file between the C# and TS history-details formatters #1463
The W6 history Details text is formatted twice on purpose: in C# for the Excel and in TS for the page. Parity rests on 22 input-to-output vectors copied by hand into the TS spec table. A C# change that also updates its own test does not turn the TS side red, so drift is unguarded. The reason for the duplication is written down only in the PR body, not in the two doc comments.
eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-history.helper.spec.ts (vector table, from about line 47)
eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Services/ChemicalReporting/ChemicalHistoryDetailsFormatter.cs and eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-history.helper.ts:157 (formatHistoryDetails)
BackendConfiguration.Pn.Test/Services/ChemicalHistoryWordsParityTests.cs already reads eform-client files, so it is the model for the fix.
Suggested fix
One JSON vector file read by both the C# test and the TS spec. Add the why-duplicated paragraph to both doc comments.
Origin
Plan E final review m-8, PR #1437 (merged as a81a41b).
Activity