Skip to content

Kemi: share one vector file between the C# and TS history-details formatters #1463

Open

Description

@renemadsen

What is wrong

The W6 history Details text is formatted twice on purpose: in C# for the Excel and in TS for the page. Parity rests on 22 input-to-output vectors copied by hand into the TS spec table. A C# change that also updates its own test does not turn the TS side red, so drift is unguarded. The reason for the duplication is written down only in the PR body, not in the two doc comments.

Where (stable a81a41b)

  • eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-history.helper.spec.ts (vector table, from about line 47)
  • eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn.Test/Services/ChemicalHistoryDetailsFormatterTests.cs
  • eFormAPI/Plugins/BackendConfiguration.Pn/BackendConfiguration.Pn/Services/ChemicalReporting/ChemicalHistoryDetailsFormatter.cs and eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/helpers/chemical-history.helper.ts:157 (formatHistoryDetails)
  • BackendConfiguration.Pn.Test/Services/ChemicalHistoryWordsParityTests.cs already reads eform-client files, so it is the model for the fix.

Suggested fix

One JSON vector file read by both the C# test and the TS spec. Add the why-duplicated paragraph to both doc comments.

Origin

Plan E final review m-8, PR #1437 (merged as a81a41b).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testingE2E/Playwright test coverage

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions