Skip to content

Kemi: register-placement dialog discards typed input without a confirm #1462

Open

Description

@renemadsen

What is wrong

The register-placement dialog is the only Kemi dialog whose Cancel discards typed input without asking. The four W2 dialogs and the location dialog use cancelPlacementDialog / cancelChemicalDialog. The T13 ruling scoped the discard confirm to the W2 dialogs. Copilot flagged the same on PR #1437 and it was answered as a follow-up. The loss is a search plus one pick, so it is low cost, but it is inconsistent. The PR body states this openly.

Where (stable a81a41b)

eform-client/src/app/plugins/modules/backend-configuration-pn/modules/chemicals/components/chemical-register-placement-dialog/chemical-register-placement-dialog.component.ts:101-106 (cancel())

Suggested fix

Use cancelChemicalDialog with disableClose, as the other dialogs do, and add a spec that Cancel on a dirty draft asks first. Keep Cancel blocked while a registration is in flight (M2).

Origin

Plan E final review m-7, PR #1437 (merged as a81a41b); Copilot comment 4306046385.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions