Repository navigation
Angular 21: standalone components, Vitest and angular19 CI - #1285
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
No concrete defects were identified, but the cross-repository migration still needs CI and browser validation.
No open issues 🎉
What changed in this PR
Prepares the Greate Belt plugin for the frontend’s Angular 21 migration through standalone components and compatible build tooling.
Changes:
- Moves template dependencies into standalone components, including the missing
MatTooltipimport. - Makes PR CI check out matching frontend and sibling-plugin branches.
- Enables Corepack before Yarn installs, builds Docker assets with Yarn, and removes obsolete WDIO comments.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/greate-belt-pn/layouts/greate-belt-pn-layout.component.ts | Makes the layout standalone with RouterOutlet. |
| eform-client/src/app/plugins/modules/greate-belt-pn/greate-belt-pn.module.ts | Removes declarations and template imports; retains routing, state, and providers. |
| eform-client/src/app/plugins/modules/greate-belt-pn/components/report/report-page/report-table/report-table.component.ts | Adds standalone table dependencies and tooltip support. |
| eform-client/src/app/plugins/modules/greate-belt-pn/components/report/report-page/report-container/report-container.component.ts | Adds standalone container dependencies. |
| Dockerfile | Enables Corepack and builds with Yarn. |
| .github/workflows/dotnet-core-pr.yml | Aligns dependency branches and enables Corepack. |
| .github/workflows/dotnet-core-master.yml | Enables Corepack and removes obsolete WDIO comments. |
Review effort: Balanced
…vide it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Angular 21 upgrade. The frontend's
angular19branch is now on Angular 21 with standalone components and Vitest (microting/eform-angular-frontend#8155).yarn install, because the frontend'sangular19pins Yarn 4. The Dockerfile builds the frontend with yarn. Dead WDIO copy steps are removed.declarationsare removed.MatTooltip, which its template used but the old module never provided.Verified locally with
ng buildagainst frontendangular19, together with the other migrated plugins. Code reviewed. Not yet clicked through in a browser.🤖 Generated with Claude Code