Repository navigation
Angular 21: standalone components, Vitest and angular19 CI - #1173
Merged
Merged
Conversation
PR CI checks out the frontend (and sibling plugins) at the branch the PR targets instead of always stable. Corepack is enabled before every yarn install, since the frontend's angular19 branch pins yarn@4; the Docker build uses yarn for the frontend build as well. Dead WDIO config copies are dropped (the frontend no longer has WDIO). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ervices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-repository CI compatibility and runtime dialog behavior still need verification before approval.
No open issues 🎉
What changed in this PR
Migrates the customers plugin to standalone components for compatibility with the Angular 21 frontend.
Changes:
- Adds component-level template imports and removes NgModule declarations while retaining dialog and service providers.
- Makes PR CI select the frontend branch matching the PR target.
- Enables Corepack before dependency installation in CI and Docker.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/customers-pn/layouts/customer-pn-layout.component.ts | Imports RouterOutlet directly. |
| eform-client/src/app/plugins/modules/customers-pn/customers-pn.module.ts | Removes declarations and retains feature providers. |
| eform-client/src/app/plugins/modules/customers-pn/components/customers-pn-table/customers-pn-table.component.ts | Adds standalone table dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customers-pn-fields/customers-pn-fields.component.ts | Adds standalone field-settings dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customers-pn-container/customers-pn-container.component.ts | Imports child components and template dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customer-pn-import/customer-pn-import.component.ts | Adds standalone import-page dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customer-pn-edit/customer-pn-edit.component.ts | Adds edit-dialog and reactive-form dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customer-pn-delete/customer-pn-delete.component.ts | Adds delete-dialog dependencies. |
| eform-client/src/app/plugins/modules/customers-pn/components/customer-pn-add/customer-pn-add.component.ts | Adds add-dialog and reactive-form dependencies. |
| Dockerfile | Enables Corepack before Yarn installation. |
| .github/workflows/dotnet-core-pr.yml | Aligns frontend checkout with the target branch and enables Corepack. |
| .github/workflows/dotnet-core-master.yml | Enables Corepack before Yarn installation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Angular 21 upgrade. The frontend's
angular19branch is now on Angular 21 with standalone components and Vitest (microting/eform-angular-frontend#8155).yarn install, because the frontend'sangular19pins Yarn 4.declarationsare removed.MatDialogModulestays in the feature modules, so plugin dialogs still resolve module-provided services.Verified locally with
ng buildagainst frontendangular19, together with the other migrated plugins. Code reviewed. Not yet clicked through in a browser.🤖 Generated with Claude Code