Repository navigation
ci: run the DB configuration with Playwright - #1169
Merged
Merged
Conversation
The DB configuration step still ran the legacy Cypress spec against eform-angular-frontend stable, which removed the constants that spec imports in May, so the step failed on every run. Use the Playwright DB configuration, as the other plugins do. closes #1168 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The updated paths and commands align with the frontend Playwright configuration and existing CI setup.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates database configuration CI from obsolete Cypress tests to the frontend’s Playwright suite.
Changes:
- Updates database constants to target the Docker MariaDB host.
- Waits for the application before running Playwright database configuration tests.
- Applies the migration to pull-request and branch workflows.
| File | Description |
|---|---|
.github/workflows/dotnet-core-pr.yml |
Migrates PR database configuration testing to Playwright. |
.github/workflows/dotnet-core-master.yml |
Migrates branch database configuration testing to Playwright. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1168
Job
pn-playwright-test(bothdotnet-core-master.ymlanddotnet-core-pr.yml) still ran the legacy Cypress speccypress/e2e/db/*against eform-angular-frontendstable. Frontend removed the constants that spec imports (991ac571e, 2026-05-02), so "DB Configuration" has failed on every run since (e.g. stable run 36400200829).Replaced with the Playwright DB configuration used by the other plugins (reference: microting/eform-angular-greate-belt-plugin#1278): sed on
playwright/e2e/Constants/DatabaseConfigurationConstants.ts, wait for the app,npx playwright test playwright/e2e/Tests/database-configuration/. The job already installs Playwright browsers, so no extra step.Verified: YAML parses; frontend paths exist on
stable; same steps as the merged greate-belt fix. The PR run is the real test.Note: the plugin's own Playwright specs that run after this step have not been reached in recent runs, so they run for the first time in a while.
🤖 Generated with Claude Code