Fix TranslateWindowsPath when USERPROFILE is a disk root#1476
Open
LeviPesin wants to merge 5 commits into
Open
Fix TranslateWindowsPath when USERPROFILE is a disk root#1476LeviPesin wants to merge 5 commits into
LeviPesin wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix TranslateWindowsPath so Windows drive-root paths like D: are translated correctly to WSL paths (avoiding Weston/app failures when USERPROFILE points to a drive root), per issue #1475.
Changes:
- Modifies how the
wslpathcommand line is constructed forTranslateWindowsPath. - Extends output trimming to remove trailing
/in addition to\n.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Tested and it works perfectly for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1475
My attempt at fixing it,
untestednow tested.Works by adding a slash to the Windows path being converted to WSL's one (i.e.
D:gets converted toD:/, and even if there already is a slash in the end (would break in any case later) it still works fine) and removing it after the conversion.Copilot has also requested me to add a check that
resultis not empty.