Skip to content

fix: fixed issue #2344 #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Limborx wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −4
Open

fix: fixed issue #2344 #2380

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab802f
fix: fixed issue #2344
Limborx Jun 28, 2026
f8c5bf7
Formatted Code
Limborx Jun 28, 2026
653dec2
fixed issue #2344, Change log level from warn to error for unknown se…
Limborx Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/cdp/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ export default class Connection {
if (!session) {
const disposedDate = this._disposedSessions.get(object.sessionId);
if (!disposedDate) {
throw new Error(
`Unknown session id: ${object.sessionId} while processing: ${object.method}`,
);
this.logger.error(LogTag.Internal,`Unknown session id: ${object.sessionId} while processing: ${object.method}`);
} else {
const secondsAgo = (Date.now() - disposedDate.getTime()) / 1000.0;
this.logger.warn(
Expand All @@ -122,7 +120,7 @@ export default class Connection {
const eventName = object.method;
let error: Error | undefined;
try {
session._onMessage(object);
session?._onMessage(object);
} catch (e) {
error = e;
}
Expand Down