This repository was archived by the owner on Aug 24, 2026. It is now read-only.
Fix install check when multiple major versions installed - #190
Merged
David Barbet (dibarbet) merged 1 commit intoAug 6, 2025
Conversation
David Barbet (dibarbet)
marked this pull request as ready for review
August 6, 2025 21:35
Jason Malinowski (jasonmalinowski)
approved these changes
Aug 6, 2025
Member
|
Looks like we're being broken by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2521866 |
Member
Author
|
failure is known, bypassing to unblock builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original registry key being checked (e.g.
VisualStudio.DTE.17.0) is overwritten when a new major version is installed. So if you have both installed side by side, the older instance is never found.instead of using this registry key, just use the same discovery logic we use to find an instance to launch later on.