put license in files that will be copied into other repros - #3
Open
Nick Maliwacki (KnicKnic) wants to merge 2 commits into
Open
put license in files that will be copied into other repros#3Nick Maliwacki (KnicKnic) wants to merge 2 commits into
Nick Maliwacki (KnicKnic) wants to merge 2 commits into
Conversation
Heath Stewart (heaths)
requested changes
Sep 7, 2018
Heath Stewart (heaths)
left a comment
Heath Stewart (heaths)
left a comment
Member
There was a problem hiding this comment.
At this point, you may as well remove the LICENSE.txt files from the subdirectories and update the CONTRIBUTING.md file with instructions to put the license text directly into covered files.
Author
|
Updated Contributing.md Kept LICENSE.txt as github will detect that and mark the license for the repository |
Heath Stewart (heaths)
requested changes
Sep 7, 2018
Heath Stewart (heaths)
left a comment
Heath Stewart (heaths)
left a comment
Member
There was a problem hiding this comment.
The license in the README is not necessary and just complicates reading when raw. Please remove. The contribution changes look good. I was thinking that I also put the licenses in each directory but apparently did not (there was some discussion of this with legal but we decided not to go that route). After that I can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix issue #2
Heath Stewart (@heaths)