Skip to content

[kdstatemachineeditor] Update to 2.3.1 - #53429

Draft
SunBlack (SunBlack) wants to merge 1 commit into
microsoft:masterfrom
SunBlack:kdstatemachineeditor
Draft

[kdstatemachineeditor] Update to 2.3.1#53429
SunBlack (SunBlack) wants to merge 1 commit into
microsoft:masterfrom
SunBlack:kdstatemachineeditor

Conversation

@SunBlack

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

"graphviz",
"qt5compat",
{
"name": "graphviz",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.6 Sol suggests that this is the build failure cause:

Windows ARM64 and ARM64 static-md configuration fail because this PR changes the dependency from graphviz to graphviz[tools]. That feature makes a target-architecture dot.exe available to CMake, and upstream FindGraphviz.cmake selects and executes it during cross-compilation. The x64 build host cannot run the ARM64 executable, so version detection receives no output and fails in string(REPLACE).

The dot -V detection is not new in 2.3.1; version 2.0.0 contains materially the same Windows logic. The regression is specifically that enabling the tools feature newly exposes the target executable and triggers this pre-existing cross-compilation defect.

It suggests that:

Making graphviz[tools] host-only would remove the target Graphviz libraries that KDSME links.

A viable fix is:

  • target dependency: graphviz
  • host dependency: graphviz[tools]
  • pass DOT_TOOL=${CURRENT_HOST_INSTALLED_DIR}/tools/graphviz/dot.exe to CMake

That lets FindGraphviz.cmake inspect target libraries while executing a host-compatible dot.

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft August 14, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants