[dispenso] Update to version 1.6.0 - #53402
Conversation
There was a problem hiding this comment.
GPT 5.6 Sol reports:
- The port uses bundled
concurrentqueue, exposing a non-root public include path that breaks direct header consumption. It also installs third-party code under BSD/Boost licensing while declaring only MIT (portfile.cmake,concurrentqueue.h).
(It also complained about NOMINMAX but I don't care :) )
I understand that this is not a regression introduced by this update, so if you don't want to deal with devendoring it that's OK, but we at least need to fix the installed copyright file and "license" to note the different license of the vendored part if you decide to not devendor it.
Thanks for the update!
|
Thanks for the careful review — both points are fair. Rather than declaring the extra licenses, I've devendored: the port now depends on On the include-path point specifically: you're right that it isn't a regression here, and dispenso 1.6.1 fixes it upstream as well, so the bundled layout stops being a trap for consumers who don't go through the CMake target. Your review also caught something on our side worth fixing: dispenso's own README understated the bundled licenses — it omitted the Boost option entirely, and implied the Zlib terms applied more broadly than they do. Correcting upstream now. Thanks again! |
|
Correction to my previous comment: I said devendoring resolves the include-path point too. It doesn't — I'd misread the That port installs its headers to So this update fixes the licensing point squarely — dispenso now installs no third-party code, and For what it's worth, dispenso 1.6.1 does fix the layout on the bundled path upstream (the vendored headers move to the include root), so source builds and anything not going through the CMake target stop hitting it. |
4d81e2b to
c39ec96
Compare
|
Correction to my previous comment: I said devendoring resolves the include-path point too. It doesn't — I'd misread the That port installs its headers to So this update fixes the licensing point squarely — dispenso now installs no third-party code, and For what it's worth, dispenso 1.6.1 will fix the layout on the bundled path upstream (the vendored headers move to the include root), so source builds and anything not going through the CMake target stop hitting it. |
Port Update Checklist
./vcpkg x-add-version --allUpdate dispenso to version 1.6.0.
This also clears the two 1.5.0-era workarounds. Both have been unnecessary
since dispenso 1.5.1, and neither is needed by 1.6.0:
fix-arm64-platform-define.patch. [dispenso] Bump to 1.5.1 #50867 dropped thePATCHESreference but left the file itself behind. Billy O'Neal (@BillyONeal) asked in[dispenso] Update to version 1.5.1 #50888 that it be removed "next time the port is touched" — this is that PR.
-DDISPENSO_SHARED_LIB=${DISPENSO_SHARED}and thestring(COMPARE EQUAL ...)line feeding it. UpstreamCMakeLists.txthasdefaulted
DISPENSO_SHARED_LIBto${BUILD_SHARED_LIBS}since 1.5.1, so theport no longer has to force it;
VCPKG_LIBRARY_LINKAGEnow drives linkagethrough the standard mechanism.