[lightlib] Add port: lightlib version 0.1.4 - #53328
Draft
NikSimDev wants to merge 7 commits into
Draft
Conversation
Author
|
@microsoft-github-policy-service agree |
Billy O'Neal (BillyONeal)
requested changes
Aug 10, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
- Some other reason (The project lightlib has been in private development for over 1.5 years to ensure a stable and production-ready codebase. It has been publicly developed and available for the last 3 months, with active maintenance. We believe this combined period demonstrates equivalent maturity to the 6-month public development requirement)
Unfortunately that doesn't seem to be a reason to disregard the usual maturity rules. The point of those is about how people will use the component in question, not a statement about the quality of the code inside. It's a statement about the kind of churn we see when things first become publicly available and not wanting to sign up to resolve that churn.
- The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
- The project is in Repology: https://repology.org/project//versions
- The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
- The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent
Owner-Projectform.
This is not true; GitHubOrg-GitHubRepo would be lev2p1-lightlib. The name "light" is extremely generic and adding "lib" suffixes is not considered disambiguating under https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#example-ambiguous-port-name
Additionally, GPT 5.6 Sol reports the following:
- A Debug consumer of
lightlib::lightliblinks the Release lightlib archives and fails with MSVC runtime/iterator-level mismatches. The port declaresvcpkg-cmake-configbut never callsvcpkg_cmake_config_fixup(). Additionally, the upstream aggregate target links both the static and shared libraries, and the port's static-linkage branch deletes the shared DLLs while leaving exported shared targets that require them. Package only the selected linkage, export one usable consumer target, and validate both Release and Debug.- Upstream calls
find_package(OpenSSL REQUIRED), exportsOpenSSL::SSLandOpenSSL::Crypto, and exposes OpenSSL headers in public headers; relying on another dependency to install it transitively is not sufficient.- Convert
ports/lightlib/portfile.cmaketo LF, remove trailing whitespace, and add the final newline.- Install both upstream license texts. The LGPLv3 text incorporates GPLv3, and upstream supplies
LICENSE(LGPLv3) andCOPYING(GPLv3); pass both tovcpkg_install_copyright.- Remove the unused
picojsondependency.- Replace the
boostmeta-port with the specific Boost component ports required by the build to avoid installing the entire Boost collection.- Remove the redundant explicit
CMAKE_TOOLCHAIN_FILEoption and the unnecessaryVCPKG_POLICY_DLLS_WITHOUT_EXPORTS; the produced Windows DLL has exports.
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 10, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new port for the lightlib library, a modern C++ MVC framework for high-performance APIs. The port has been tested on Windows (x64), Linux (x64), and macOS (x64).
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.