Skip to content

[curve-coco] Update to 4.7.2 - #53307

Open
SunBlack (SunBlack) wants to merge 3 commits into
microsoft:masterfrom
SunBlack:curve-coco
Open

[curve-coco] Update to 4.7.2#53307
SunBlack (SunBlack) wants to merge 3 commits into
microsoft:masterfrom
SunBlack:curve-coco

Conversation

@SunBlack

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

SunBlack (SunBlack) and others added 2 commits August 7, 2026 14:42
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! GPT 5.6 Sol reports:

  • The port manifest advertises 4.7.2, but portfile.cmake only points config fixup at the incorrectly versioned upstream directory. Upstream still declares VERSION 4.7.1, so find_package(coco 4.7.2 CONFIG REQUIRED) rejects the installed package as version 4.7.1.
  • Headers and archives are installed below include/coco-4.7.1 and lib/coco-4.7.1 rather than the triplet's root include/lib directories. Consequently, direct Release and Debug consumers cannot include <coco/...> and find no root *.lib files.
  • Upstream unconditionally creates a STATIC library, but the port accepts dynamic-linkage triplets.

Would you consider SunBlack#34 ?

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft August 8, 2026 06:27
[curve-coco] Fix 4.7.2 package layout
@SunBlack
SunBlack (SunBlack) marked this pull request as ready for review August 9, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants