[curve-coco] Update to 4.7.2 - #53307
Open
SunBlack (SunBlack) wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
Thanks for the update! GPT 5.6 Sol reports:
- The port manifest advertises 4.7.2, but
portfile.cmakeonly points config fixup at the incorrectly versioned upstream directory. Upstream still declaresVERSION 4.7.1, sofind_package(coco 4.7.2 CONFIG REQUIRED)rejects the installed package as version 4.7.1.- Headers and archives are installed below
include/coco-4.7.1andlib/coco-4.7.1rather than the triplet's root include/lib directories. Consequently, direct Release and Debug consumers cannot include<coco/...>and find no root*.libfiles.- Upstream unconditionally creates a
STATIClibrary, but the port accepts dynamic-linkage triplets.
Would you consider SunBlack#34 ?
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 8, 2026 06:27
[curve-coco] Fix 4.7.2 package layout
SunBlack (SunBlack)
marked this pull request as ready for review
August 9, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.