[minifb] Update to 0.10.1 - #53302
Merged
Merged
Conversation
SunBlack (SunBlack)
force-pushed
the
minifb
branch
5 times, most recently
from
August 7, 2026 12:55
d9ba45e to
25193ab
Compare
SunBlack (SunBlack)
force-pushed
the
minifb
branch
from
August 7, 2026 13:27
25193ab to
10c6c49
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
requested changes
Aug 8, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
Thanks for the update!
- ports/minifb/usage is substantially identical to generated usage and can be removed.
ports/minifb/portfile.cmakeremains CRLF-only; the added lines consequently triggergit diff --check. Normalize the touched file to LF.
Would you consider SunBlack#33 ?
It also reports this but given the lack of clarity we have about the whole X libs situation I don't think we should try to fix that right now:
MiniFB 0.10.1 conditionally enables XRandR whenever CMake happens to find it, but the port neither declares/forces that dependency nor disables the probe. Please make the result deterministic, normally by submitting or carrying a focused upstreamable option/patch and explicitly disabling XRandR unless a controlled dependency is provided. See CMakeLists.txt.
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 8, 2026 06:15
[minifb] LFize, remove usage
SunBlack (SunBlack)
marked this pull request as ready for review
August 9, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.