[fastdds] Update to 3.6.2 - #53298
Merged
Merged
Conversation
Billy O'Neal (BillyONeal)
requested changes
Aug 8, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
Thanks for the update! GPT 5.6 Sol reports the following:
find_package(fastdds CONFIG REQUIRED)fails during generation because the exportedfastddstarget referencesnlohmann_json::nlohmann_json, whilefastdds-config.cmakedoes not callfind_dependency(nlohmann_json CONFIG REQUIRED).- A direct MSVC consumer using only the installed include root and all installed
.libfiles fails because Fast DDS auto-linkslibfastdds-3.6.lib/libfastddsd-3.6.lib, but the dynamic package installsfastdds-3.6.lib/fastddsd-3.6.lib. Please disable or correct upstream auto-linking for the vcpkg package without requiring consumer-defined macros.- The Windows install leaves
fast-discovery-server.exesymlinks targeting versioned executables that the port subsequently moves/removes. The resulting broken links also caused vcpkg's binary-cache archive step to fail. Please remove or relocate both Release and Debug aliases consistently.- The package compiles vendored Boost, PEGTL, FileWatch, optionparser, and SQLite code, but declares only
Apache-2.0and installs only the top-level Apache license.vcpkg_copy_tool_dependencies()is deprecated; usevcpkg_copy_tools().ports/fastdds/usageis stored with CRLF line endings; non-patch port files should use LF.
[...]
The custom usage file is necessary. Generated usage incorrectly recommends:
target_link_libraries(main PRIVATE fastdds::optionparser)
Would you consider SunBlack#32 ?
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 8, 2026 05:57
[fastdds] Fix package integrations and licensing
SunBlack (SunBlack)
marked this pull request as ready for review
August 9, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.