Skip to content

[opencc] Update to 1.4.1 - #53294

Open
SunBlack (SunBlack) wants to merge 3 commits into
microsoft:masterfrom
SunBlack:opencc
Open

[opencc] Update to 1.4.1#53294
SunBlack (SunBlack) wants to merge 3 commits into
microsoft:masterfrom
SunBlack:opencc

Conversation

@SunBlack

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! GPT 5.6 Sol had a few suggestions:

  • OpenCC derives its version from Git metadata, which is absent from the downloaded archive, and falls back to 1.4.0. Consequently, the 1.4.1 package installs 1.4.0 CMake/pkg-config metadata and find_package(OpenCC 1.4.1 CONFIG REQUIRED) fails.
  • The exported CMake target does not resolve its RapidJSON dependency. The export records RapidJSON's canonical target name, RapidJSON, but OpenCCConfig.cmake loads OpenCCTargets.cmake without first rediscovering the RapidJSON package. CMake therefore treats RapidJSON as a plain library name and downstream linking requests nonexistent RapidJSON.lib.
  • The macOS build has an uncontrolled optional component. Upstream now defaults BUILD_OPENCC_JIEBA_PLUGIN on for top-level macOS builds, causing vendored cppjieba and RapidJSON code plus additional plugin and dictionary content to be built and installed.
  • The newly added BUILD_PYTHON and ENABLE_BENCHMARK options use tab indentation rather than the surrounding four-space style.

I got it to write SunBlack#36 ; would you consider merging that?

Preserve release metadata, propagate the RapidJSON target correctly, and disable the uncontrolled Jieba plugin build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft August 8, 2026 06:46
@SunBlack
SunBlack (SunBlack) marked this pull request as ready for review August 9, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants