[opencc] Update to 1.4.1 - #53294
Open
SunBlack (SunBlack) wants to merge 3 commits into
Open
Conversation
Billy O'Neal (BillyONeal)
requested changes
Aug 8, 2026
Member
There was a problem hiding this comment.
Thanks for the update! GPT 5.6 Sol had a few suggestions:
- OpenCC derives its version from Git metadata, which is absent from the downloaded archive, and falls back to 1.4.0. Consequently, the 1.4.1 package installs 1.4.0 CMake/pkg-config metadata and
find_package(OpenCC 1.4.1 CONFIG REQUIRED)fails.- The exported CMake target does not resolve its RapidJSON dependency. The export records RapidJSON's canonical target name,
RapidJSON, butOpenCCConfig.cmakeloadsOpenCCTargets.cmakewithout first rediscovering the RapidJSON package. CMake therefore treatsRapidJSONas a plain library name and downstream linking requests nonexistentRapidJSON.lib.- The macOS build has an uncontrolled optional component. Upstream now defaults
BUILD_OPENCC_JIEBA_PLUGINon for top-level macOS builds, causing vendored cppjieba and RapidJSON code plus additional plugin and dictionary content to be built and installed.- The newly added
BUILD_PYTHONandENABLE_BENCHMARKoptions use tab indentation rather than the surrounding four-space style.
I got it to write SunBlack#36 ; would you consider merging that?
Preserve release metadata, propagate the RapidJSON target correctly, and disable the uncontrolled Jieba plugin build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 8, 2026 06:46
[opencc] Fix 1.4.1 packaging
SunBlack (SunBlack)
marked this pull request as ready for review
August 9, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.