Repository navigation
LEGO: Pull request from juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260928124641299 to main - #2150
Merged
Billy O'Neal (BillyONeal) merged 2 commits intoSep 28, 2026
Conversation
Copilot started reviewing on behalf of
CSIGS@microsoft.com (csigs)
September 28, 2026 12:47
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regenerate and include the French and Russian locale JSON outputs.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds French and Russian translations for binary-cache compression and submission diagnostics.
Changes:
- Adds compression-level help and validation translations.
- Adds binary-cache submission failure translations.
- Generated locale JSON outputs remain unsynchronized.
| File | Summary |
|---|---|
src/localization/fr/messages.json.lcl |
Adds French localization entries; generated JSON is missing corresponding messages. |
src/localization/ru/messages.json.lcl |
Adds Russian localization entries; generated JSON is missing corresponding messages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binary cache ZIP compression level (0-9). Overrides VCPKG_BINARY_CACHE_COMPRESSION_LEVEL; unset uses the archive tool default.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Niveau de compression ZIP du cache binaire (0-9). Remplace VCPKG_BINARY_CACHE_COMPRESSION_LEVEL ; unset utilise l’outil d’archivage par défaut.]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binary cache ZIP compression level (0-9). Overrides VCPKG_BINARY_CACHE_COMPRESSION_LEVEL; unset uses the archive tool default.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Уровень сжатия ZIP-файла двоичного кэша (0–9). Переопределяет VCPKG_BINARY_CACHE_COMPRESSION_LEVEL; unset использует инструмент архивации по умолчанию.]]></Val> |
# Conflicts: # src/localization/fr/messages.json.lcl # src/localization/ru/messages.json.lcl
Copilot started reviewing on behalf of
CSIGS@microsoft.com (csigs)
September 28, 2026 19:21
View session
Billy O'Neal (BillyONeal)
approved these changes
Sep 28, 2026
Billy O'Neal (BillyONeal)
enabled auto-merge (squash)
September 28, 2026 19:21
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 28, 2026
Comment on lines
+1720
to
+1722
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Échec de l’envoi du cache binaire]]></Val> | ||
| </Tgt> |
Comment on lines
+1720
to
+1722
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[не удалось отправить двоичный кэш]]></Val> | ||
| </Tgt> |
Billy O'Neal (BillyONeal)
deleted the
juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260928124641299
branch
September 29, 2026 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260928124641299 to main with localized lcls