Skip to content

LEGO: Pull request from juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189 to main - #2101

Merged
Billy O'Neal (BillyONeal) merged 2 commits into
mainfrom
juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189
Aug 10, 2026
Merged

LEGO: Pull request from juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189 to main#2101
Billy O'Neal (BillyONeal) merged 2 commits into
mainfrom
juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189

Conversation

@csigs

Copy link
Copy Markdown
Member

LEGO: Pull request from juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189 to main with localized lcls

Copilot AI lite review requested due to automatic review settings August 8, 2026 13:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates localized LCL resources for multiple locales by adding new message IDs (notably around update-baseline, dependency reporting, and privacy/telemetry notices) and adjusting several existing English source strings while preserving prior text via <Prev> blocks.

Changes:

  • Add new localized entries: CmdUpdateBaselineOptQuiet, DirectDependencies, TransitiveDependencies, PrivacyNotice, TelemetryNotice, and several UpdateBaseline* messages.
  • Update existing message text (e.g., PortsNoDiff, UpdateBaselineNoUpdate, UpdateBaselineUpdatedBaseline) and record previous source strings with <Prev>.
  • Introduce per-locale translations for newly-added update-baseline version-diff output entries (new/removed dependency version lines).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/localization/zh-Hant/messages.json.lcl Adds/updates zh-Hant localizations for new update-baseline and notice messages.
src/localization/ru/messages.json.lcl Adds/updates Russian localizations for new update-baseline and notice messages.
src/localization/pt-BR/messages.json.lcl Adds/updates pt-BR localizations for new update-baseline and notice messages.
src/localization/ja/messages.json.lcl Adds/updates Japanese localizations for new update-baseline and notice messages.
src/localization/it/messages.json.lcl Adds/updates Italian localizations for new update-baseline and notice messages.
src/localization/es/messages.json.lcl Adds/updates Spanish localizations for new update-baseline and notice messages.
src/localization/de/messages.json.lcl Adds/updates German localizations for new update-baseline and notice messages.
src/localization/cs/messages.json.lcl Adds/updates Czech localizations for new update-baseline and notice messages.
Suppressed comments (2)

src/localization/pt-BR/messages.json.lcl:11609

  • The pt-BR translation for UpdateBaselineRemovedDependencyVersion is still in English ("removed"). This will show up as mixed-language output in the pt-BR locale.
            <Val><![CDATA[{package_name}: removed: {version}]]></Val>

src/localization/it/messages.json.lcl:11612

  • The Italian translation for UpdateBaselineRemovedDependencyVersion is still in English ("removed"). This should be localized for the it locale.
            <Val><![CDATA[{package_name}: removed: {version}]]></Val>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

<Str Cat="Text">
<Val><![CDATA[{package_name}: new: {version}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[{package_name}: new: {version}]]></Val>
<Str Cat="Text">
<Val><![CDATA[{package_name}: new: {version}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[{package_name}: new: {version}]]></Val>
Copilot AI review requested due to automatic review settings August 10, 2026 19:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (6)

src/localization/pt-BR/messages.json.lcl:11571

  • This new pt-BR string is still in English ("new"). Since other locales translate this label, consider localizing it here as well for consistency.
          <Val><![CDATA[{package_name}: new: {version}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[{package_name}: new: {version}]]></Val>
          </Tgt>

src/localization/it/messages.json.lcl:11574

  • This new Italian string is still in English ("new"). Since other locales translate this label, consider localizing it here as well for consistency.
          <Val><![CDATA[{package_name}: new: {version}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[{package_name}: new: {version}]]></Val>
          </Tgt>

src/localization/de/messages.json.lcl:11598

  • The German translation still wraps {value} in quotes even though the source string removed quoting (likely to avoid doubled quoting when values already contain quotes). Consider removing the quotes around {value} to match the updated message formatting.
          <Val><![CDATA[registry '{url}' not updated: {value}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[Registry „{url}“ nicht aktualisiert: „{value}“]]></Val>
          </Tgt>

src/localization/de/messages.json.lcl:11619

  • The German translation still wraps {old_value}/{new_value} in quotes even though the source string removed quoting. Consider removing those quotes so the output formatting matches other locales and the updated English message.
          <Val><![CDATA[updated registry '{url}': {old_value} -> {new_value}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[aktualisierte Registry „{url}“: „{old_value}“ -> „{new_value}“]]></Val>
          </Tgt>

src/localization/pt-BR/messages.json.lcl:11610

  • This new pt-BR string is still in English ("removed"). Consider localizing it to pt-BR for consistency with other translated locales.
          <Val><![CDATA[{package_name}: removed: {version}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[{package_name}: removed: {version}]]></Val>
          </Tgt>

src/localization/it/messages.json.lcl:11613

  • This new Italian string is still in English ("removed"). Consider localizing it to Italian for consistency with other translated locales.
          <Val><![CDATA[{package_name}: removed: {version}]]></Val>
          <Tgt Cat="Text" Stat="Loc" Orig="New">
            <Val><![CDATA[{package_name}: removed: {version}]]></Val>
          </Tgt>

@BillyONeal
Billy O'Neal (BillyONeal) merged commit e08a6f4 into main Aug 10, 2026
8 checks passed
@BillyONeal
Billy O'Neal (BillyONeal) deleted the juno/hb_cb3056d7-d122-4ef4-8657-e36080a7f8c6_20260808134634189 branch August 10, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants