[Rework] Binary Cache: Add write-back support - #1597
Open
Francisco Facioni (fran6co) wants to merge 2 commits into
Open
[Rework] Binary Cache: Add write-back support#1597Francisco Facioni (fran6co) wants to merge 2 commits into
Francisco Facioni (fran6co) wants to merge 2 commits into
Conversation
Francisco Facioni (fran6co)
marked this pull request as draft
February 12, 2025 15:07
Francisco Facioni (fran6co)
force-pushed
the
fran/write_back
branch
from
February 13, 2025 00:52
7e7afcd to
01f89c9
Compare
Francisco Facioni (fran6co)
force-pushed
the
fran/write_back
branch
3 times, most recently
from
February 13, 2025 01:06
6cab351 to
5edae6e
Compare
Francisco Facioni (fran6co)
force-pushed
the
fran/write_back
branch
from
February 13, 2025 01:10
5edae6e to
2b020bc
Compare
Francisco Facioni (fran6co)
marked this pull request as ready for review
February 13, 2025 01:18
Contributor
Author
|
I'm not sure I like the |
Contributor
Author
|
In any case, I think push_success should check if the package is there already to avoid uploading when it doesn't need to. I could add the check just on writeback, but is there a reason why it's set to overwrite on push_success even if the package is already there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to implement #1406 with the new changes in the code