feat(check_approval): add support for pre and post approval kinds - #1556
Open
Luiz Felipe Machado (luizfelmach) wants to merge 2 commits into
Open
feat(check_approval): add support for pre and post approval kinds#1556Luiz Felipe Machado (luizfelmach) wants to merge 2 commits into
Luiz Felipe Machado (luizfelmach) wants to merge 2 commits into
Conversation
|
Closes #1586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
Adds support for selecting the approval check kind in
azuredevops_check_approval.Azure DevOps uses different
settings.definitionRef.idvalues for standard approvals, pre-check approvals, and post-check approvals, but the provider previously only modeled a generic approval check. This change adds a new optionalapproval_kindattribute so users can explicitly manage these variants through Terraform.Supported values:
approvalpre_checkpost_checkThis change also updates the flatten/expand logic to map
approval_kindto the correctsettings.definitionRef.id, updates the resource documentation, and adds test coverage for the new behavior.Does this introduce a breaking change?
Test Result