Add validation for permission names in security permissions resource - #1545
Open
Levente Laszlo Papp (aklakina) wants to merge 1 commit into
Open
Add validation for permission names in security permissions resource#1545Levente Laszlo Papp (aklakina) wants to merge 1 commit into
Levente Laszlo Papp (aklakina) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Description
The generic permission set resource had a state bug when it was trying to do update on a resource with faulty configuration.
The implementation did not check during diff time that the permission set given is valid for the namespace and during apply time it already saved the new faulty permission set. This meant that a faulty plan could go green and a faulty apply caused the resource to be corrupted and this broke every subsequent plan until resource remove from tf state. This PR fixes this issue.
Does this introduce a breaking change?
Test Result
Related Issue(s)
Fix #0000
Other information