Skip to content

Add validation for permission names in security permissions resource - #1545

Open
Levente Laszlo Papp (aklakina) wants to merge 1 commit into
microsoft:mainfrom
aklakina:fix/security/false-apply
Open

Add validation for permission names in security permissions resource#1545
Levente Laszlo Papp (aklakina) wants to merge 1 commit into
microsoft:mainfrom
aklakina:fix/security/false-apply

Conversation

@aklakina

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

Description

The generic permission set resource had a state bug when it was trying to do update on a resource with faulty configuration.
The implementation did not check during diff time that the permission set given is valid for the namespace and during apply time it already saved the new faulty permission set. This meant that a faulty plan could go green and a faulty apply caused the resource to be corrupted and this broke every subsequent plan until resource remove from tf state. This PR fixes this issue.

Does this introduce a breaking change?

  • Yes
  • No

Test Result

Related Issue(s)

Fix #0000

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant