Skip to content

Python: fix(google_ai): report more Gemini finish reasons as content_filter #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into from
Oct 26, 2026
+29 −1
Merged

Python: fix(google_ai): report more Gemini finish reasons as content_filter #14632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion python/semantic_kernel/connectors/ai/google/google_ai/services/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@
logger: logging.Logger = logging.getLogger(__name__)


# Finish reasons where Gemini stopped the response for the content, not for length or a natural end.
_GOOGLE_AI_CONTENT_FILTER_REASONS = frozenset({
FinishReason.SAFETY,
FinishReason.RECITATION,
FinishReason.BLOCKLIST,
FinishReason.PROHIBITED_CONTENT,
FinishReason.SPII,
FinishReason.IMAGE_SAFETY,
FinishReason.IMAGE_PROHIBITED_CONTENT,
})


def finish_reason_from_google_ai_to_semantic_kernel(
finish_reason: FinishReason | None,
) -> SemanticKernelFinishReason | None:
Expand All @@ -47,7 +59,7 @@ def finish_reason_from_google_ai_to_semantic_kernel(
if finish_reason == FinishReason.MAX_TOKENS:
return SemanticKernelFinishReason.LENGTH

if finish_reason == FinishReason.SAFETY:
if finish_reason in _GOOGLE_AI_CONTENT_FILTER_REASONS:
return SemanticKernelFinishReason.CONTENT_FILTER

return None
Expand Down
16 changes: 16 additions & 0 deletions python/tests/unit/connectors/ai/google/google_ai/services/test_google_ai_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ def test_finish_reason_from_google_ai_to_semantic_kernel():
assert finish_reason_from_google_ai_to_semantic_kernel(None) is None


@pytest.mark.parametrize(
"reason",
[
FinishReason.RECITATION,
FinishReason.BLOCKLIST,
FinishReason.PROHIBITED_CONTENT,
FinishReason.SPII,
FinishReason.IMAGE_SAFETY,
FinishReason.IMAGE_PROHIBITED_CONTENT,
],
)
def test_content_filter_finish_reasons_from_google_ai(reason):
"""Responses Gemini stopped for their content are reported as content filtered."""
assert finish_reason_from_google_ai_to_semantic_kernel(reason) == SemanticKernelFinishReason.CONTENT_FILTER


def test_format_user_message():
"""Test format_user_message."""
user_message = ChatMessageContent(role=AuthorRole.USER, content="User message")
Expand Down
Loading